test(e2e): Port deno E2E test app to span streaming - #24002
Open
msonnb wants to merge 1 commit into
Open
Conversation
Removes the `traceLifecycle: 'static'` pin from the `deno` app and rewrites its specs against streamed spans. Adds `deno-static` as a verbatim copy of the pre-port app to keep the static trace lifecycle covered, and removes `deno-streamed`, which is now a strict subset of `deno`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
msonnb
force-pushed
the
ms/deno-e2e-span-streaming
branch
from
September 3, 2026 12:04
a7e4f3e to
8876a67
Compare
Contributor
size-limit report 📦
|
This was referenced Sep 3, 2026
msonnb
marked this pull request as ready for review
September 3, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
denoE2E app to span streaming.deno-staticis added as a verbatim copy ofdenobefore the port so the static trace lifecycle stays covered for this group. Only the app name changes, plus it's added to the CI Deno setup condition. Following #23817, the copy drops thedeno (latest)optional variant so it adds one CI row rather than two.deno-streamedis removed. Oncedenoitself is streamed it's a strict subset of it, so its two strict span-shape assertions were folded intodeno'stransactions.test.tsinstead. That required--allow-syson thedenostart script, whichdeno-streamedalready had, so theos.*/device.*segment attributes are populated. The deferredSentry.flush()fromdeno-streamedwas not carried over: it predates the default segment-end flush from #23714.Decisions taken:
Deno.servehas no route information, so streamedhttp.serversegments are namedGETonly. The specs identify requests via theurl.pathattribute.deno-statickeepsdeno-streamed's position in the required Deno setup condition, anddeno-streamedis dropped from the optional job's condition.Part of #23812
🤖 Generated with Claude Code