Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A digest mismatch blocks runtime training, while unaudited retrieval and unrecorded exports bypass learning-data safeguards needed for recall auditing, consent withdrawal, and redaction follow-ups.
12 open issues
Record disclosure receipts for transferred tasksets · New Use the runtime's semantic taskset digest algorithm · New Audit learning text retrieval sent to the runtime · New Resolve the sign-in origin consistently in the worker · New Choose one deterministic capture group per route · New Expose planner coverage before enforcing training readiness · New Use stable capture metadata and content-derived snapshot IDs · New Select review grants independently from training grants · New Translate learning-lock contention into HTTP 409 · New Fetch the requested Build without training-only selection rules · New Reconcile the recovery schedule when runtime configuration is removed · New Reject missing artifact storage before worker readiness · New
What changed in this PR
Connects the decision-model control plane from #301 to Hub’s stored Build screenshots and consent-filtered learning evidence, preparing private tasksets for customer-operated runtimes.
Changes:
- Adds bounded taskset composition, pinned input digests, and preflight coverage.
- Wires API and worker dependencies and checks the runtime’s transferred taskset digest.
- Projects Build evaluation findings without learning text and adds preview exports, tests, and documentation.
| File | Description |
|---|---|
packages/learning/test/cli.test.mjs |
Covers preview-export output. |
packages/learning/src/store.mjs |
Supports exports without durable export records. |
packages/learning/src/cli.mjs |
Exposes export preview mode. |
packages/learning/README.md |
Documents preview-export behavior. |
packages/learning/index.d.mts |
Types the export preview option. |
hub/server/workers/index.ts |
Validates decision-runtime configuration at startup. |
hub/server/workers/configuration.ts |
Registers configured training and recovery jobs. |
hub/server/start-server-processes/index.ts |
Accepts decision-model route dependencies. |
hub/server/run-api/index.ts |
Passes decision-model dependencies into API composition. |
hub/server/routes/api/decision-model/types.ts |
Expands preflight and evaluation response contracts. |
hub/server/routes/api/decision-model/index.test.ts |
Removes learning-text expectations from findings. |
hub/server/routes/api/decision-model/create-decision-model-route-dependencies/index.ts |
Projects evaluation digests, availability, and explanations. |
hub/server/repositories/decision-training-builds/list-decision-training-builds/index.ts |
Selects repository-scoped reviewed prototypes and Builds. |
hub/server/repositories/decision-training-builds/list-decision-training-builds/index.db.test.ts |
Covers selection eligibility, ordering, and isolation. |
hub/server/repositories/decision-model-configurations/get-decision-model-overview/index.db.test.ts |
Covers repository-scoped evaluation retrieval. |
hub/server/index.ts |
Composes the taskset source and decision-model API. |
hub/server/domains/decision-model/types.ts |
Adds detailed coverage and private finding contracts. |
hub/server/domains/decision-model/process-decision-training-job/index.ts |
Rejects mismatched runtime taskset digests. |
hub/server/domains/decision-model/orchestrate-decision-training/index.test.ts |
Covers transfer mismatch and revised findings. |
hub/server/domains/decision-model/evaluate-build-with-decision-model/index.ts |
Generates explanations without copying learning text. |
hub/server/domains/decision-model/errors.ts |
Adds repository and Build lookup errors. |
hub/server/domains/decision-model/create-hub-decision-taskset-source/index.ts |
Composes evidence, artifacts, preflight, uploads, and evaluation inputs. |
hub/server/domains/decision-model/create-hub-decision-taskset-source/index.test.ts |
Covers determinism, artifact checks, bounds, and cleanup. |
hub/server/domains/decision-model/create-decision-model-store/index.ts |
Persists explanations instead of learning text. |
hub/server/domains/decision-model/create-configured-decision-model-job-processors/index.ts |
Lazily composes worker storage, source, and runtime dependencies. |
hub/docs/decision-model-control-plane.md |
Documents taskset preparation and evaluation integration. |
hub/docs/architecture.md |
Describes the composed decision-model boundary. |
docs/decision-model.md |
Updates Hub taskset-transfer prerequisites. |
Review effort: Max (adaptive)
alliscode
force-pushed
the
alliscode-decision-taskset-source
branch
from
November 19, 2026 20:31
f2bb263 to
29ae79b
Compare
alliscode
force-pushed
the
alliscode-decision-taskset-source
branch
from
November 19, 2026 20:46
c4262c7 to
cf109b1
Compare
alliscode
force-pushed
the
alliscode-decision-taskset-source
branch
from
November 19, 2026 21:33
cf109b1 to
31b7447
Compare
Base automatically changed from
alliscode-hub-decision-control-plane
to
build/hub/new
November 19, 2026 21:37
alliscode
force-pushed
the
alliscode-decision-taskset-source
branch
from
November 19, 2026 21:47
31b7447 to
06bdb0f
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
alliscode
force-pushed
the
alliscode-decision-taskset-source
branch
from
November 20, 2026 00:12
ddbc138 to
7eb5c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why
The decision control plane needs a production source for private training tasksets before Hub can submit customer-operated training jobs. The source must use the new Hub's stored Builds, review evidence, learning contracts, and provider-neutral artifact storage without bringing back Rails behavior or leaking evidence across repositories.
What changes
Hub now selects eligible reviewed prototypes and published successful Builds, reads their captured pages from artifact storage, and combines them with consent-filtered learning evidence through the
packages/learningdecision contracts. It pins the evidence, Build, question, and taskset digests; exposes deterministic preflight coverage and missing-evidence reasons; stages private data within fixed resource limits; transfers one idempotent runtime upload; and cleans temporary files on success or failure.Completed Build evaluations remain in the existing control-plane record. Their overview projection includes the candidate and promotion generation, exact submitted page views, probabilities, timestamps, and bounded Hub-generated explanations. Private learning and comment text stays in the learning store rather than being copied into PostgreSQL or API findings.
This PR is stacked on the finalized decision control plane in #301. A conforming customer runtime still supplies the taskset upload, cancellation, training, promotion, and evaluation interfaces; Hub does not add a runtime server, model storage, automatic promotion, Azure-specific code, UI, or browser-capture changes.