Repository navigation
Conversation
Author
|
Closing — keeping these fixes local rather than upstreaming. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A session whose wrapper dies without a clean exit (closed terminal, killed process) stays at
exitCode: -1until the reaper finalizes it at the next session-start. But nothing flushes it afterwards:flushPendingSubmissionsruns on clean ends, and a reaped session's only other trigger is another session ending cleanly. If sessions keep dying uncleanly — laptop sleep, closed tabs — reaped work sits unsubmitted indefinitely. I lost a 13-commit session this way this week.Fix
refreshAndReap()/reapOrphanedSessions()/refreshRecentSessions()now return how many sessions they settled.onSessionStartcallsflushPendingSubmissionswhen that count is non-zero, so the session-start that reaps a session also sends it. Quiet starts still spend no time on the network.Tests
test/flush-on-reap.test.mjs(3 cases): reap returns count and submits; clean-end re-finalize keeps momentum; no flush on a start that settled nothing.