Repository navigation
[6/9] Add pinned CODA contract conformance tooling - #3571
Dmitrii Shilov (bk201-) wants to merge 5 commits into
Conversation
Integration Tests
|
✅ Build (Compile, Lint, Prettier, l10n, Package)🧱 Step Results
📥 Artifacts (run) |
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 10 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
🧪 Unit Tests🧪 Results
📈 Coverage |
🎭 E2E Tests (Playwright + VS Code)🧪 Result
|
89409b9 to
937236d
Compare
937236d to
f5165c7
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The pinned private CODA scenarios are unavailable here, so a maintainer with private-source access must verify fixture fidelity and the claimed 379-scenario conformance pass.
No open issues 🎉
What changed in this PR
Adds optional, pinned CODA contract verification for the Account Overview advisory stack, keeping private upstream scenarios separate from ordinary builds and unit tests.
Changes:
- Adds immutable checkout acquisition, integrity checks, and explicit private-runner safeguards.
- Parses Gherkin scenarios and binds DX-001 through DX-024 to production evaluators, with local conformance reports.
- Adds synthetic tooling regressions, contributor documentation, and private-file exclusions.
| File | Description |
|---|---|
vitest.coda.config.ts |
Defines a separate, single-worker conformance suite. |
tsconfig.vitest.json |
Includes the conformance test configuration in type checking. |
tsconfig.eslint.json |
Includes the conformance configuration in linting scope. |
src/panels/accountOverview/services/advisories/conformance/shared.ts |
Defines shared fixture state and assertion helpers. |
src/panels/accountOverview/services/advisories/conformance/metricsFixture.ts |
Supplies synthetic Monitor responses without network access. |
src/panels/accountOverview/services/advisories/conformance/features.ts |
Loads and compiles Gherkin scenarios. |
src/panels/accountOverview/services/advisories/conformance/features.test.ts |
Tests parsing, binding execution, and rejection paths. |
src/panels/accountOverview/services/advisories/conformance/coda.conformance.ts |
Executes selected contracts and writes scenario reports. |
src/panels/accountOverview/services/advisories/conformance/bindings.ts |
Resolves steps and checks evaluator–registry agreement. |
src/panels/accountOverview/services/advisories/conformance/bindingCoverage.test.ts |
Adds synthetic coverage across detector bindings. |
src/panels/accountOverview/services/advisories/conformance/additionalFixtures.ts |
Maps scenario context steps to production-shaped fixtures. |
src/panels/accountOverview/services/advisories/conformance/additionalBindings.ts |
Connects additional detectors, readers, and outcome assertions. |
scripts/coda.test.mjs |
Tests pin validation, acquisition, and cache integrity. |
scripts/coda.mjs |
Fetches verified revisions and launches guarded conformance runs. |
package.json |
Adds the CODA pin, commands, dependencies, and tooling-test integration. |
package-lock.json |
Locks the added Gherkin dependencies. |
eslint.config.mjs |
Excludes private CODA files from ESLint. |
CONTRIBUTING.md |
Documents conformance commands, scope, and privacy boundaries. |
.vscodeignore |
Excludes private CODA files from VSIX packaging. |
.oxlintrc.jsonc |
Excludes private CODA files from Oxlint. |
.oxfmtrc.json |
Excludes private CODA files from formatting. |
.gitignore |
Ignores private checkouts and conformance reports. |
Review effort: Balanced
f5165c7 to
38b53d7
Compare
38b53d7 to
09ace6d
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The private pinned CODA scenarios and original fixture bindings are unavailable, so an upstream reviewer must verify fixture fidelity and the claimed 379-scenario pass before contract conformance can be established.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
6d85435 to
dc48ebd
Compare
8ba323b to
c641f5c
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
An authorized reviewer must verify fixture and binding fidelity against the unavailable private pinned CODA contracts and confirm the claimed full 379-scenario run before relying on conformance.
No open issues 🎉
Review effort: Balanced
c641f5c to
8906a5a
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The pinned private CODA corpus is unavailable, so an upstream reviewer must verify binding fidelity and the claimed 379-scenario pass, which synthetic regressions alone cannot establish.
No open issues 🎉
Review effort: Balanced
8906a5a to
47409de
Compare
47409de to
ce0a8bf
Compare
Add integrity-checked local source acquisition, Gherkin scenario bindings, synthetic tooling regressions, and private cache/report exclusions without fetching contracts during ordinary builds or tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the same relative materiality denominator as the registered DX-011 detector. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the pin, test command and scenario claims from PR two to the layer that actually adds them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Do not replace supplied upstream partition histories with synthesized peak samples. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ce0a8bf to
18518f1
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Binding fidelity and the claimed 379-scenario conformance pass require verification by a reviewer with authorized access to the unavailable pinned private CODA scenarios.
No open issues 🎉
1 resolved since last review
Review effort: Balanced

Summary
Add integrity-checked acquisition of an immutable CODA revision, Gherkin scenario parsing, production-evaluator bindings for DX-001 through DX-024, synthetic tooling regressions and local conformance reports.
Ordinary builds and unit tests do not fetch or execute private upstream contracts. Private checkouts and reports are ignored, excluded from lint/format and VSIX packaging, and are not uploaded as public artifacts. Public Actions execution of private scenarios is refused without an explicit trusted-private-runner opt-in.
Stack
Part 6 of 9 in the Account Overview advisory stack. Depends on #3570. Base: dev/dshilov/account-overview-05-cost-estimates.
Each subsequent PR targets its predecessor branch so GitHub can represent the chain as a native PR stack.
Validation
The integrated stack passed localization generation, oxfmt, lint, all TypeScript build targets, and all unit suites. The full unit command used VITEST_MAX_WORKERS=2 to avoid local resource-contention timeouts. Intermediate runtime branches also passed builds and focused regressions.
Review fixes are committed to their originating PR layers; descendants are rebased onto the updated predecessors.