Repository navigation
Clarify date-time fallback docs and simplify parsing (#1337) - #1338
Merged
Merged
Conversation
Contributor
Author
|
I found no bug in #1338 or #1339, and both are safe to merge. I reported 5 low-severity findings, fewer than the 7-finding target, because I didn't want to invent more.
Findings:
|
Contributor
Author
|
I checked the pushed diffs of #1338 and #1339. I did not re-run the tests or check CI, so I'm relying on your 108-test result on JDK 25 and Java 8. Fixed:
Skipped:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the
timechangelog entry: missing seconds were already rejected. Describe the RFC 3339 fallback in README and document its space-separator and leap-second-table differences from Ethlo.Share UTC minute normalization between time and date-time validation, make seconds mandatory in the formatter, and reuse the parsed date for leap-second checks. Add regression coverage for the space-separator difference, fixed-width fields, extreme-offset leap seconds, and accepted/rejected leap seconds through schema validation with Ethlo absent.
Initial implementation validation:
mvn -B verifypassed on JDK 17, 21, and 25: 9,105 tests per run, zero failures/errors, 30 skipped. Focused format tests passed (103 cases). Refreshed GitNexus change scan: LOW risk, seven changed files.Review follow-up: document Ethlo's rejection of
-00:00, offsets beyond ±18:00, and fractions longer than nine digits, and restore the leap-second accuracy caveat. Add five date-range boundary cases, including a written year0000that normalizes to UTC year-1. The final format suite passes 108 tests with zero failures/errors/skips on JDK 25. Full-suite results above apply to the initial implementation; the docs-and-tests follow-up was checked with the focused suite. GitNexus follow-up scan: LOW risk, three changed files.Refs #1337. Companion PR for
2.x: #1339.