Repository navigation
Clarify date-time fallback docs and simplify parsing on 2.x (#1337) - #1339
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the #1337 date-time follow-ups to
2.x: correct thetimechangelog, describe the RFC 3339 fallback, and document its space-separator and leap-second-table differences from Ethlo.Share UTC minute normalization, require seconds in the formatter, and reuse the parsed date for leap-second checks. Add regression coverage for the documented separator difference, fixed-width fields, extreme-offset leap seconds, and schema validation with Ethlo absent.
Initial implementation validation:
mvn -B clean verifypassed on Java 8;mvn -B verifypassed on JDK 11, 17, and 21. Each run: 8,979 tests, zero failures/errors, 15 skipped. Refreshed GitNexus change scan: LOW risk, seven changed files.Review follow-up: document Ethlo's rejection of
-00:00, offsets beyond ±18:00, and fractions longer than nine digits, and restore the leap-second accuracy caveat. Add five date-range boundary cases, including a written year0000that normalizes to UTC year-1. The final format suite passes 108 tests with zero failures/errors/skips on Java 8. Full-suite results above apply to the initial implementation; the docs-and-tests follow-up was checked with the focused suite. GitNexus follow-up scan: LOW risk, three changed files.Refs #1337. Companion PR for
master: #1338.