Repository navigation
refactor: use one size name per control height - #975
Open
rohanchkrabrty wants to merge 3 commits into
Open
rohanchkrabrty wants to merge 3 commits into
rohanchkrabrty wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 38 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
1 task done
Member
|
@rohanchkrabrty why micro -> xsmall ? for scale. |
This was referenced Oct 19, 2026
Auto margins stopped a stretched vertical middle line from growing, so it rendered 0px tall. The upgrading note no longer says middle is always longer than half and small.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
medium: Buttonnormal, andlargeon Input, TextArea, Search, Combobox.Input, Command.Input, Checkbox, Radio and Switch. Pixel sizes and defaults do not change.microtoxsmallandregulartomedium.smallstays the default.size(small,half,full) withvariant(full,middle).middleinsets both ends of the line.Decisions where the proposal is silent:
middleinsets each end by 16px on a horizontal line and 8px on a vertical line, as MUI Dividermiddledoes. The line is centered.halfandsmallboth map tomiddle, so the length of those lines changes (they were 50% and 20px).smallstays 22px, and Badge stays 18, 22 and 28px. These do not match the 24px and 32px rule. They are open items for design.mediumkeep their current sizes.xsmall, as the proposal says. An earlier analysis usedextra-small..medium,size-medium,badge-xsmall). The new Separator classes arevariant-fullandvariant-middle.docs/V1-migration.mdkeeps the old names, because it describes the 1.0 release.size="half". The Input playground usesdefaultValue, so the default size is left out of the generated code.No open PR covers this change. Badge
variantandicon, and Separatorcolor, are renamed in separate PRs.Checks run:
pnpm lint,pnpm exec tsc --noEmitinpackages/react, andpnpm test:apsarapass. I compared 17 docs pages on a local dev server with the deployed docs (main) in light and dark themes. The computed size, spacing and color of every demo part match. Only the demo labels and the Separator demos differ.