Skip to content

PM-6628: Refresh Marathon Match submission modals - #7290

Merged
jmgasper merged 1 commit into
developfrom
PM-6628
Oct 20, 2026
Merged

jmgasper merged 1 commit into
developfrom
PM-6628

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken

Marathon Match submission history and artifact dialogs used legacy layouts. History had no working artifact action, Download all was missing, and Community App modals still used the old backdrop and shadows.

Root cause

The dialogs retained legacy markup/styles, and the shared Modal defaults had not been updated for the new design system.

What was changed

  • Match the supplied MM designs with submission IDs, handle, sortable submission dates, score states, artifact icons/tooltips, and Close controls.
  • Show only the example artifact before completion. After completion, show every artifact authorized by the existing API and offer a single Download all ZIP.
  • Connect history to artifact details, preserve non-MM history, and display artifact request failures.
  • Apply a 50% black backdrop and remove shadows for shared Community App modals, including custom layout themes.
  • Update modal documentation and document the download helpers.

Any added/updated tests

  • Add 17 regression tests for artifact visibility, individual/bulk downloads, errors, history sorting/navigation, and shared modal themes.
  • npm run lint: passed.
  • npm test: 494 tests and 141 snapshots passed; 23 existing tests skipped.
  • NODE_OPTIONS=--max_old_space_size=8192 npm run build: passed.
  • Headless Chrome checks using the real components and mocked API responses: desktop/mobile layout, sorting, history/artifact transitions, shared backdrop/shadow styles, individual download, and a generated ZIP containing all four artifacts passed.

All Node/npm commands used the project's Node version via nvm use. No dependency changes or API changes.

What was broken

MM submission history and artifact dialogs used legacy layouts. History lacked
working artifact navigation, Download all was unavailable, and Community App
modals used the old backdrop and container shadows.

Root cause

The dialogs retained separate legacy markup and styles, and the shared Modal
defaults had not been updated for the new design system.

What was changed

Add the MM history table with submission IDs, sortable dates, member handle,
score states, and artifact actions. Restyle artifacts with submission metadata,
example-only access before completion, and a single ZIP download after
completion. Reuse API authorization and the existing ZIP utility, surface
request failures, and apply a 50% black backdrop without shadows to shared
Community App modals. Document the shared defaults and download helpers.

Any added/updated tests

Add 17 regression tests covering artifact visibility, individual and bulk
downloads, failure handling, history sorting and navigation, and shared themes.
All 494 tests and 141 snapshots pass; 23 previously skipped tests remain skipped.
Lint and the production build pass. Headless browser checks with mocked API
responses verify desktop/mobile layouts, modal transitions, backdrop styles,
and an actual ZIP containing all four artifacts.
@jmgasper
jmgasper requested a review from kkartunov as a code owner October 19, 2026 19:51
@jmgasper
jmgasper merged commit 367d3c1 into develop Oct 20, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant