Repository navigation
Conversation
Autofill model.bundle models onto the TensorRT backend and keep plan files on tensorrt_plan. Signed-off-by: Yingge He <yinggeh@nvidia.com>
Merged
7 of 20 tasks
 [Medium impact] The PR appears safe to merge, with the previous coverage gap addressed and no new blocking issues found. SummaryRecognizes
Reviews (2) · Last reviewed commit: "test: Cover model_connect platform autof..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
yinggeh
marked this pull request as draft
October 29, 2026 16:55
Signed-off-by: Yingge He <yinggeh@nvidia.com>
whoisj
approved these changes
Nov 2, 2026
Contributor
|
Obviously, do not merge before the backend changes are in place. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Recognizes
model_connectandmodel.bundleas a TensorRT backend model. Plan files still autofill astensorrt_plan.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/tensorrt_backend#133
Where should the reviewer start?
src/model_config_utils.ccautofill, thensrc/test/repo_agent_test.cc.Test plan:
TensorRTBundleAutofillcovers an explicit bundle, filename autofill, sniffingmodel.bundle, and the plan path when a plan file is present.Caveats:
Autofill only. Execution is in the backend PR.
Background
A model_connect config with an empty backend or platform should resolve to the TensorRT backend without changing plan models.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)