Repository navigation
Conversation
Run one model_connect request at a time for text generation, text continuation, and structured ranking, while plan models stay on the existing path. Signed-off-by: Yingge He <yinggeh@nvidia.com>
7 of 20 tasks
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issue was established. SummaryThe PR adds Model Connect bundle serving alongside the existing plan path.
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Model initialization] --> B{Model type}
B -->|Plan| C[Existing plan path]
B -->|Model Connect| D[Read bundle header]
D --> E[Load matching task]
E --> F[Copy one request to host]
F --> G[Run text or ranking task]
G --> H[Write response and release request]
Reviews (2) · Last reviewed commit: "fix: Read Model Connect SDK errors after..." · Reviewed by Greptile |
whoisj
requested changes
Oct 29, 2026
whoisj
left a comment
There was a problem hiding this comment.
LGTM with the exception that I don't think any of the new files are being compiled.
Have they been added to the CMakeLists.txt file?
Add the model_connect sources to the backend library and find the installed SDK on the default search path. Signed-off-by: Yingge He <yinggeh@nvidia.com>
Store each SDK status before reading its error pointer, pass text views by reference, and copy the result owner into the output. Signed-off-by: Yingge He <yinggeh@nvidia.com>
whoisj
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Serves a Model Connect bundle from the TensorRT backend, one request at a time.
text_generationandtext_continuationtake one string or one token-id sequence.structured_rankingtakes named numeric tensors. Plan models stay on the existing path.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/core#541
Where should the reviewer start?
src/tensorrt.ccfor the plan versus model_connect dispatch, thensrc/model_connect/instance_state.ccfor load and execute.Test plan:
Loaded dazr, ajk50, ajk64, feed, and gpt2 one at a time. Compared each Triton response with the native SDK on the same inputs. Every output matched.
Caveats:
One request at a time. No batching and no streaming. The ranking path is built against the private SDK.
Background
The bundle task is read from the bundle header before the model is loaded.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)