feat(stovepipe): add request logs for process owned states - #665
Merged
Conversation
Summary: Intent: - Retain the admitted request state before dependent Build work begins. - Let redelivery repair a missing processing occurrence from durable Request state. Changes: - Persist processing logs after a successful state transition and on already-processing retries. - Block hook and Build publication until materialization succeeds. - Wire the shared request-log materializer into Process and cover transition and retry failures. Revert Plan: - Revert this change to stop recording processing-state request-log entries. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
September 2, 2026 22:10
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 2, 2026 22:10
This was referenced Sep 2, 2026
mnoah1
changed the title
sbalabanov
approved these changes
Sep 4, 2026
mnoah1
added a commit
that referenced
this pull request
Sep 9, 2026
Summary: This PR builds on #665, which records Process-owned request states. Intent: - Retain terminal build outcomes before the request advances to Record. - Let BuildSignal redelivery repair a missing terminal occurrence from durable state. Changes: - Persist succeeded, failed, and cancelled request logs with their build outcome reasons. - Keep the request CAS and slot release ahead of materialization, and materialization ahead of Record publication. - Wire the shared materializer into BuildSignal and cover transition and retry failures. Test Plan: - Run the BuildSignal controller, server wiring, and request-log materializer Bazel tests. Revert Plan: - Revert this change to stop recording BuildSignal terminal outcomes. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
added a commit
that referenced
this pull request
Sep 9, 2026
Summary: This PR builds on #665, which records Process-owned request states. Intent: - Retain terminal build outcomes before the request advances to Record. - Let BuildSignal redelivery repair a missing terminal occurrence from durable state. Changes: - Persist succeeded, failed, and cancelled request logs with their build outcome reasons. - Keep the request CAS and slot release ahead of materialization, and materialization ahead of Record publication. - Wire the shared materializer into BuildSignal and cover transition and retry failures. Test Plan: - Run the BuildSignal controller, server wiring, and request-log materializer Bazel tests. Revert Plan: - Revert this change to stop recording BuildSignal terminal outcomes. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
added a commit
that referenced
this pull request
Sep 9, 2026
Summary: This PR builds on #665, which records Process-owned request states. Intent: - Retain terminal build outcomes before the request advances to Record. - Let BuildSignal redelivery repair a missing terminal occurrence from durable state. Changes: - Persist succeeded, failed, and cancelled request logs with their build outcome reasons. - Keep the request CAS and slot release ahead of materialization, and materialization ahead of Record publication. - Wire the shared materializer into BuildSignal and cover transition and retry failures. Test Plan: - Run the BuildSignal controller, server wiring, and request-log materializer Bazel tests. Revert Plan: - Revert this change to stop recording BuildSignal terminal outcomes. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
aeonframework
pushed a commit
to aeonframework/submitqueue
that referenced
this pull request
Sep 10, 2026
…ber#666) ## Summary This PR builds on uber#665, which records Process-owned request states. Intent: - Retain terminal request outcomes and the durable build/fact milestones that explain them. - Let queue redelivery repair any missing occurrence before downstream work continues. Changes: - Persist succeeded, failed, and cancelled request states with their build outcome reasons. - Record build_triggered, build_finished, and validation_fact_recorded events with stable identities and bounded metadata. - Keep each source write ahead of event materialization and materialization ahead of downstream publication or derived work. - Wire the shared materializer into Build, BuildSignal, and Record. ## Test Plan - Run the focused Build, BuildSignal, Record, request-log materializer, and server wiring Bazel tests. ## Revert Plan - Revert this change to stop recording terminal outcomes and lifecycle events. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub> ## Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Test Plan
Revert Plan
Issues
Stack