Skip to content

feat(stovepipe): add request logs for dlq outcomes - #667

Merged
mnoah1 merged 1 commit into
mnoah1/stovepipe-request-history-build-outcomesfrom
mnoah1/stovepipe-request-history-dlq-outcomes
Sep 9, 2026
Merged

feat(stovepipe): add request logs for dlq outcomes#667
mnoah1 merged 1 commit into
mnoah1/stovepipe-request-history-build-outcomesfrom
mnoah1/stovepipe-request-history-dlq-outcomes

Conversation

@mnoah1

@mnoah1 mnoah1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR builds on #666, which records normal request outcomes and lifecycle events.

Intent:

  • Retain the terminal reason when an exhausted pipeline stage forces a request to fail.
  • Repair a missing failure occurrence when DLQ reconciliation redelivers after the request write.

Changes:

  • Record processing_failed for Process and Build DLQ reconciliation.
  • Record build_polling_exhausted for BuildSignal DLQ reconciliation.
  • Persist the failed request state before its log and preserve all other terminal outcomes.
  • Wire the shared request-log materializer into the three DLQ controllers.

Test Plan

  • Exercise new failure logging, retry repair, write ordering, stage-specific reasons, and server wiring in Bazel tests.

Revert Plan

  • Revert this change to leave DLQ reconciliation state-only.

Generated by the 🪄 pr-create skill in devexp-agent-marketplace

AI Verification

Validated at 81789e9 on Sep 9 21:46 UTC · 21 files analyzed · 2s

Validator Status Issues
go-coverage not_applicable 0
ios-test not_applicable 0
web not_applicable 0
diff-template not_applicable 0
android-lint not_applicable 0
android-coverage not_applicable 0
uber-one not_applicable 0
go-thrift-lint not_applicable 0
java-lint not_applicable 0
java-coverage not_applicable 0
ios-lint not_applicable 0
go-lint not_applicable 0
go-proto-lint not_applicable 0
custom not_applicable 0
ureview completed 0

0 issues detected

Skipped validators: claude · EngWiki

Issues

@mnoah1
mnoah1 marked this pull request as ready for review September 2, 2026 22:50
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners September 2, 2026 22:50
@mnoah1 mnoah1 changed the title feat(stovepipe): record DLQ request failures feat(stovepipe): add request logs for dlq outcomes Sep 2, 2026
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-dlq-outcomes branch from 45d6797 to 1c5bf36 Compare September 9, 2026 15:00
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-dlq-outcomes branch from 1c5bf36 to 8209337 Compare September 9, 2026 15:32
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-dlq-outcomes branch from 8209337 to 0fa24d2 Compare September 9, 2026 18:42
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-dlq-outcomes branch from 0fa24d2 to 81789e9 Compare September 9, 2026 21:47
Summary:
This PR builds on #666, which records normal request outcomes and lifecycle events.

Intent:
- Retain the terminal reason when an exhausted pipeline stage forces a request to fail.
- Repair a missing failure occurrence when DLQ reconciliation redelivers after the request write.

Changes:
- Record processing_failed for Process and Build DLQ reconciliation.
- Record build_polling_exhausted for BuildSignal DLQ reconciliation.
- Persist the failed request state before its log and preserve all other terminal outcomes.
- Wire the shared request-log materializer into the three DLQ controllers.

Test Plan:
- Exercise new failure logging, retry repair, write ordering, stage-specific reasons, and server wiring in Bazel tests.

Revert Plan:
- Revert this change to leave DLQ reconciliation state-only.

---

<sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
@mnoah1
mnoah1 force-pushed the mnoah1/stovepipe-request-history-dlq-outcomes branch from 81789e9 to 2888a5e Compare September 9, 2026 21:55
@mnoah1
mnoah1 added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit e5d5a86 Sep 9, 2026
15 of 27 checks passed
@mnoah1
mnoah1 deployed to stack-rebase September 9, 2026 22:06 — with GitHub Actions Active
@behinddwalls
behinddwalls deleted the mnoah1/stovepipe-request-history-dlq-outcomes branch September 9, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants