Repository navigation
fix(ui): keep wallpaper crop stable across desktop zoom - #2294
Conversation
Issue: #2292 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2314 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
|
Final-head review — 2026-10-20 JST Base Dependency base #2317 fixes #2314; latest required CI is queued during the active GitHub Actions degradation. No remote green result is claimed. Full stack summary, local validation and exact run links: #2245 checkpoint. All PRs remain Draft/unmerged; native evidence retains its original artifact scope. Refreshed local HTML explainers are not published artifacts. GitHub image rendering remains unverified under the existing browser-policy restriction; committed image references were checked for existence and decodable dimensions locally. |
…zoom-cover # Conflicts: # pnpm-workspace.yaml
Issue #2292 · based on main · Agent claim
Why the change
Keep the wallpaper covering the full Bot workspace with the same crop when desktop UI zoom changes.
Special things to note
codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264. Native evidence uses the same isolated macOS DSH 0.2.1-rc.2 Profile. Final integrated macOS windowed/fullscreen Human QA passed; merged after final CI and authorized review; native video decoding is not newly qualified.Change outline
Validated: 13 focused tests (including image/video/poster geometry over 17 levels, resize, crop, resource identity/disposal), real Chromium fixture at 34 zoom/viewport combinations, all 17 levels in the native visible DSH window, Client build, lint, typecheck, format and changelog checks. The baseline test fails on origin/main and retains a failure screenshot. No whole-suite or new native-codec claim. A separate HTML page is omitted because the coordinate correction is linear and fully shown above.
macOS window, 1261 × 820 CSS px, 83% UI zoom, generated grid wallpaper — the original exposed white right/bottom regions; the fix covers the window. Header gap/corner backing remain tracked separately in #2293.
Before

After

Native 17-level measurements · Chromium 34-case measurements
Closes #2292
Review refresh (2026-10-20): latest main is integrated; source semantic diffs remain unchanged. Fresh Standards/Spec review and CI bind to
6c5b43541f9e573fd0dd7fb354daf8945217e5fa. Current stack: main → #2294 → #2295 → #2298 → #2299. #2317 is closed/superseded by merged #2319. Native evidence retains its recorded artifact scope; default reset/keypad #2318 and Windows/Linux #2270 remain outstanding. The Human authorizes merge after all gates pass; no release.Merged to main as
761b62baa04d9af4fb4fdcf8d81503ce9e409b77after exact-head CI and both review axes passed. No release.