Skip to content

fix(ui): let wallpaper show through workspace chrome - #2295

Merged
DoodleBears merged 5 commits into
mainfrom
codex/2293-wallpaper-chrome
Oct 19, 2026
Merged

DoodleBears merged 5 commits into
mainfrom
codex/2293-wallpaper-chrome

Conversation

@DoodleBears

@DoodleBears DoodleBears commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Issue #2293 · Agent claim · stacked after #2294

Why the change

Let wallpaper show through Bot workspace header gaps and the macOS traffic-light safe area without hiding native controls.

Special things to note

  • Merge risk: two-way door, revert this CSS change; small blast radius, wallpaper-active Bot workspace paint only. Review cascade specificity, header background clipping and safe-area geometry; no upstream, persistence or drag/hit-area changes.
  • Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264. Native DSH 0.2.1-rc.2 reuses the existing isolated Profile; Final integrated macOS windowed/fullscreen Human QA passed; merged after final CI and authorized review. The purple sharing indicator in windowed captures is macOS system UI and remains intact.

Change outline

- light canvas rules override wallpaper's transparent header border and corner paint
+ scoped wallpaper rules win in either stylesheet order
+ transparent header border + padding-box paint keep wallpaper visible in the gap
+ macOS corner paint becomes transparent; 88 × 40 safe area and title clearance stay

The stripe is application-owned workspace border paint, not an upstream native titlebar defect. The macOS-only backing is our workspace safety overlay. The clip rule also wins over functional Panel background shorthands, retaining their configured alpha and blur; Header/Body material colors stay configurable; removing wallpaper restores the original canvas. A separate HTML page is omitted because this bounded CSS cascade change is fully shown above.

Validated: 64 production-CSS Chromium combinations (light/dark, window/fullscreen, both stylesheet orders, global/per-Panel Header materials, representative zoom extremes), 68 native zoom/theme/window-state combinations, native fullscreen entry/exit, 2,035 Client tests passed / 1 existing skip, lint, typecheck, format, changelog and full build. Available CDP cached console had zero exceptions/errors/warnings; native Host diagnostics were unavailable. Original media bytes/crop and effective preferences were restored after testing. The 68-case native matrix is checkpoint 2c32667, before the final selector strengthening for per-Panel overrides; the final refinement passes all 64 production-CSS combinations and a live native 100% computed-style check. The full native matrix was not repeated after that refinement. No new native-codec or Windows/Linux qualification.

Windowed macOS — 1261 × 820 CSS px, 83% UI zoom, generated grid

Before: opaque safe-area backing and pale header line.
Before: opaque macOS corner backing and header border

After: wallpaper blends through; native control reservation remains.
After: transparent macOS corner backing and header gap

Fullscreen macOS — 1470 × 923 CSS px, same zoom and theme

Before:
Before: pale header border in native fullscreen

After:
After: wallpaper visible through header gap in native fullscreen

Verification and limits

Closes #2293

Review refresh (2026-10-20): latest main is integrated; source semantic diffs remain unchanged. Fresh Standards/Spec review and CI bind to f4851bde53728a5bb5ad49f34a7bc8e9743e0da0. Current stack: main → #2294 → #2295 → #2298 → #2299. #2317 is closed/superseded by merged #2319. Native evidence retains its recorded artifact scope; default reset/keypad #2318 and Windows/Linux #2270 remain outstanding. The Human authorizes merge after all gates pass; no release.

Merged to main as ef4856d5a75887a3583338acaf7aa0d3ef91ffb6 after exact-head CI and both review axes passed. No release.

Issue: #2293

Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Issue: #2293

Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
@DoodleBears

Copy link
Copy Markdown
Contributor Author

Final-head review — 2026-10-20 JST

Base e3d35458c → head 2d16e296e. Independent Standards and Spec reviews found no remaining new findings. The scoped semantic patch is unchanged by the new main/Expo base propagation.

Dependency base #2317 fixes #2314; latest required CI is queued during the active GitHub Actions degradation. No remote green result is claimed. Full stack summary, local validation and exact run links: #2245 checkpoint.

All PRs remain Draft/unmerged; native evidence retains its original artifact scope. Refreshed local HTML explainers are not published artifacts. GitHub image rendering remains unverified under the existing browser-policy restriction; committed image references were checked for existence and decodable dimensions locally.

@DoodleBears
DoodleBears marked this pull request as ready for review October 19, 2026 17:21
@DoodleBears
DoodleBears changed the base branch from codex/2292-wallpaper-zoom-cover to main October 19, 2026 17:28
@DoodleBears
DoodleBears merged commit ef4856d into main Oct 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ui): remove opaque workspace header and macOS corner backing over wallpaper

1 participant