Repository navigation
fix(ui): let wallpaper show through workspace chrome - #2295
Conversation
Issue: #2293 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2293 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
|
Final-head review — 2026-10-20 JST Base Dependency base #2317 fixes #2314; latest required CI is queued during the active GitHub Actions degradation. No remote green result is claimed. Full stack summary, local validation and exact run links: #2245 checkpoint. All PRs remain Draft/unmerged; native evidence retains its original artifact scope. Refreshed local HTML explainers are not published artifacts. GitHub image rendering remains unverified under the existing browser-policy restriction; committed image references were checked for existence and decodable dimensions locally. |
Issue #2293 · Agent claim · stacked after #2294
Why the change
Let wallpaper show through Bot workspace header gaps and the macOS traffic-light safe area without hiding native controls.
Special things to note
codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264. Native DSH 0.2.1-rc.2 reuses the existing isolated Profile; Final integrated macOS windowed/fullscreen Human QA passed; merged after final CI and authorized review. The purple sharing indicator in windowed captures is macOS system UI and remains intact.Change outline
The stripe is application-owned workspace border paint, not an upstream native titlebar defect. The macOS-only backing is our workspace safety overlay. The clip rule also wins over functional Panel background shorthands, retaining their configured alpha and blur; Header/Body material colors stay configurable; removing wallpaper restores the original canvas. A separate HTML page is omitted because this bounded CSS cascade change is fully shown above.
Validated: 64 production-CSS Chromium combinations (light/dark, window/fullscreen, both stylesheet orders, global/per-Panel Header materials, representative zoom extremes), 68 native zoom/theme/window-state combinations, native fullscreen entry/exit, 2,035 Client tests passed / 1 existing skip, lint, typecheck, format, changelog and full build. Available CDP cached console had zero exceptions/errors/warnings; native Host diagnostics were unavailable. Original media bytes/crop and effective preferences were restored after testing. The 68-case native matrix is checkpoint
2c32667, before the final selector strengthening for per-Panel overrides; the final refinement passes all 64 production-CSS combinations and a live native 100% computed-style check. The full native matrix was not repeated after that refinement. No new native-codec or Windows/Linux qualification.Windowed macOS — 1261 × 820 CSS px, 83% UI zoom, generated grid
Before: opaque safe-area backing and pale header line.

After: wallpaper blends through; native control reservation remains.

Fullscreen macOS — 1470 × 923 CSS px, same zoom and theme
Before:

After:

Verification and limits
Closes #2293
Review refresh (2026-10-20): latest main is integrated; source semantic diffs remain unchanged. Fresh Standards/Spec review and CI bind to
f4851bde53728a5bb5ad49f34a7bc8e9743e0da0. Current stack: main → #2294 → #2295 → #2298 → #2299. #2317 is closed/superseded by merged #2319. Native evidence retains its recorded artifact scope; default reset/keypad #2318 and Windows/Linux #2270 remain outstanding. The Human authorizes merge after all gates pass; no release.Merged to main as
ef4856d5a75887a3583338acaf7aa0d3ef91ffb6after exact-head CI and both review axes passed. No release.