Repository navigation
fix(client): align zoomed choice menus and native tooltips - #2299
Conversation
S2 source correction published — native acceptance remains openDraft PR #2299 (stacked on #2298), head Matched 144% before/after source fixtures and full matrix: 136/136 cases pass across all 17 levels and two viewport sizes; baseline fails 132/136. Both PNGs return HTTP 200 and the PR embeds their exact-head raw URLs. These are synthetic source-component fixtures, not native DSH screenshots. The fixture accesses only its own static origin, with no Host/auth/user data. It is not access to the browser-denied fresh-product UI. After merging #2298: 24 related tests, lint, format and root/mobile types pass. Earlier unchanged Client-source full suite: 2035 passed, one existing skip. Remote CI is separate. Still open: native menu/portal/extreme-zoom acceptance in the preserved desktop, corrected packed activation, same-user-data Host switch, physical IME and the remaining focus/restore matrix. #2269 cannot yet close. #2270 is deferred for the Human Windows handoff. The current native window stays unchanged for the pending Human input step. No merge/release/upstream changes. Agent-Task: |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Refs #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Refs #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Final macOS behavior qualification — Draft PR, CI blocker retainedPR #2299 now Closes #2269 only, stacked on #2298; exact evidence head
Versioned evidence, images and limits. Earlier physical plain Equal/IME, installer, original font and Host-switch proof retain their tested version and scope; representative fixtures do not qualify arbitrary third-party pages or unknown app versions. CI is not green: the full run hit the unchanged mobile Expo-doctor patch baseline; tracked separately in #2314, with the failing job and all four mismatches. No check was bypassed. Native Windows/Linux remain #2270. #2269 stays open until review/merge; no manual issue closure. Agent-Task: |
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
|
Final-head review — 2026-10-20 JST Base Dependency base #2317 fixes #2314; latest required CI is queued during the active GitHub Actions degradation. No remote green result is claimed. Full stack summary, local validation and exact run links: #2245 checkpoint. All PRs remain Draft/unmerged; native evidence retains its original artifact scope. Refreshed local HTML explainers are not published artifacts. GitHub image rendering remains unverified under the existing browser-policy restriction; committed image references were checked for existence and decodable dimensions locally. |
Issue: #2269 Agent-Task: codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264
Issue #2269 | Agent claim | Versioned evidence and limits
Why the change
Keep shared choice menus and native tooltips aligned with their controls and inside the viewport during whole-window zoom.
Special things to note
/plugins/eventsfailures and observed automatic reconnection are preserved in the record, not labeled error-free.Change outline
Matched Select before/after at 144% are isolated source-component fixtures using the unchanged reachable native Menu/Modal code and CSS; they are not native Desktop screenshots.
The following pair is actual native Desktop output at the same 144%, viewport and Home-name focus state: installed .14 before, updated .16 after. The tooltip moves from a second-scaled coordinate to the button; the original draft and font preferences remain.
Final .16 native record and full-window guest recovery, earlier versioned native focus/menu/transport record. Representative supported paths do not qualify arbitrary third-party pages/programmatic tooltip triggers or unknown Desktop versions.
Task:
codex/local/01a1506e-87d7-7c10-b4d9-9ba86f02b264. Parent: #2245. No merge or release.Review refresh (2026-10-20): latest main is integrated; source semantic diffs remain unchanged. Fresh Standards/Spec review and CI bind to
79ff75d84911697cc05f083ba87a62a696b362db. Current stack: main → #2294 → #2295 → #2298 → #2299. #2317 is closed/superseded by merged #2319. Native evidence retains its recorded artifact scope; default reset/keypad #2318 and Windows/Linux #2270 remain outstanding. The Human authorizes merge after all gates pass; no release.Merged to main as
64315272e5247993e2c5569513703d24c2032b49after exact-head CI and independent Standards/Spec reviews passed. See final stack record. No release.